[Feat] ReadShortcutViewModel 생성 #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMM00
approved these changes
Aug 11, 2023
HanGyeongjun
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
구현/변경 사항
Publishing changes from within view updates is not allowed, this will cause undefined behavior.경고가 발생하는데 ReadShortcutView를 그릴 때 ReadShortcutViewModel에서 Publish된 속성(comments)을 초기화하는 과정에서 ShortcutsZipViewModel에서 Publish된 속성(allComments)이 업데이트되면서 발생하는 것 같아요. 제가 이해한게 맞다면 ShortcutsZipViewModel line 920에서 allComments 대신 새로운 변수를 선언하여 리턴하는 방법으로 해결해도 될까요 ??? 확인부탁드려요 ... 👀스크린샷
단축어는 작성하지 않고 추천 모음집만 작성한 경우, ShowProfileView에서의 유저 등급 이미지를 수정했습니다.